Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change messaging if metamask not installed #79

Closed
homtec opened this issue Aug 8, 2018 · 9 comments
Closed

Change messaging if metamask not installed #79

homtec opened this issue Aug 8, 2018 · 9 comments

Comments

@homtec
Copy link

homtec commented Aug 8, 2018

Now: "Loading data from Ethereum..."
Expected: instructions how to proceed

@raucao
Copy link
Member

raucao commented Aug 8, 2018

Actually, if Metamask is not installed it should just load the data from the network and show you the dashboard without any member features active.

Most likely an issue with IPFS. @gregkare was playing around with the IPFS nodes just yesterday and this morning, trying to set up a cross-datacenter cluster for better connectivity and reliability. Sometimes the objects load when you retry a second time.

@homtec
Copy link
Author

homtec commented Aug 8, 2018 via email

@raucao
Copy link
Member

raucao commented Aug 8, 2018

I might have written it in a way that's not clear: the current implementation should already work the way I described is what I meant. :)

@homtec
Copy link
Author

homtec commented Aug 8, 2018

Got it. Maybe it took some while. In this case a loading indicator would be helpful. Its working now. Thx

@raucao
Copy link
Member

raucao commented Aug 8, 2018

There's a pulsing loading indicator as well as the text you pasted. Was there no pulsing comet on the page above the text when you saw it?

@homtec
Copy link
Author

homtec commented Aug 9, 2018

There was, but I didn't recognized it as a loading indicator. I think it crashed somehow so there was no progress. If it's only expected to cover ~5sec I think its ok.

In general: What do you think to define the current "no metamask installed" flow as the default behavior? Have the "sign-in" via Metamask optional or ask if the user wants to make a transaction.

@raucao
Copy link
Member

raucao commented Aug 9, 2018

It's actually optional, just not with nice UI. You can just click cancel in the dialog and proceed without opening the wallet.

@homtec
Copy link
Author

homtec commented Aug 12, 2018

Yes, but its not the same. My suggestion is to remove any metamask interaction at this step to reduce any potential obstacle.

@bumi bumi added this to the Onboarding milestone Feb 25, 2019
@raucao
Copy link
Member

raucao commented May 1, 2019

This one is obsolete, because the alert doesn't exist anymore, and there's a whole new Metamask connect UI for allowing access to the account now.

@raucao raucao closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants