Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new balance APIs from akkounts, add Lightning balance #217

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Use new balance APIs from akkounts, add Lightning balance #217

merged 1 commit into from
Jan 14, 2024

Conversation

raucao
Copy link
Member

@raucao raucao commented Jan 12, 2024

  • Use sats integer values instead of floats (API change in akkounts)
  • Add lightning Network account balance
  • Use icons and titles/descriptions to discern between balance types
  • Use more flexible config for balances (to add e.g. RBTC or BTC ecash later)

Screenshot from 2024-01-12 14-24-44

@raucao
Use new balance APIs from akkounts
dbedf1d 
* Use sats integer values instead of floats
* Add lightning Network account balance
* Use icons and titles/descriptions to discern between balance types
* Use more flexible config for balances (to add e.g. RBTC or BTC ecash
  later)
galfert
galfert approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raucao raucao merged commit 895bf56 into master Jan 14, 2024
3 checks passed
@raucao raucao deleted the feature/budget-balances branch January 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galfert galfert galfert approved these changes

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raucao @galfert