Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper is unforgiving when trailing the Api Uri with a / #204

Closed
danhaller opened this issue Sep 30, 2014 · 3 comments
Closed

Wrapper is unforgiving when trailing the Api Uri with a / #204

danhaller opened this issue Sep 30, 2014 · 3 comments

Comments

@danhaller
Copy link
Contributor

When using the wrapper the user must create a class that implements IApiUri.

If the Uri ends in a trailing slash i.e. http://api.7digital.com/1.2/ the request url is generated with a double slash which can cause problems with OAuth endpoints because the signature calculations take the request url into account. The resulting error is misleading.

I suggest that the wrapper should be able to handle an ApiUri with or without a trailing slash.

@danhaller
Copy link
Contributor Author

I can take a look at this when I have a little more time

@AnthonySteele
Copy link
Contributor

Sounds reasonable, you might want something like Path.Combine, which is forgiving w.r.t slashes
http://stackoverflow.com/questions/372865/path-combine-for-urls

@AnthonySteele
Copy link
Contributor

PR submitted: #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants