Core #1
Merged
Core #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for naughty-franklin-3633f3 failed. 🔨 Explore the source changes: b0bae90 🔍 Inspect the deploy log: https://app.netlify.com/sites/naughty-franklin-3633f3/deploys/60fc5001fc0ad800074f8e83 |
There was a problem hiding this comment.
This is a great PR Jhon!
Only two small comments
- move the
Card.jsxfile inside its ownCardfolder. Could becomponents/Cardorcomponents/Content/Cardif you intend to group other components similar to card in the content folder. - Move the
MockData.jsfile to outside thecomponentsfolder. You could create adatafolder for this purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Challenge for Wizeline