Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distage-testkit: Fix recorded test error messages in sbt reports, scalatest xml reports, etc. #1011

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Apr 18, 2020

@alexander-branevskiy

  • preserve original class of Throwable in BIORunner.unsafeRun
  • add BIOExit.Trace.unsafeAttachTrace

@codecov-io
Copy link

codecov-io commented Apr 18, 2020

Codecov Report

Merging #1011 into develop will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1011      +/-   ##
===========================================
- Coverage    54.24%   54.18%   -0.07%     
===========================================
  Files          402      402              
  Lines         8553     8554       +1     
  Branches       470      467       -3     
===========================================
- Hits          4640     4635       -5     
- Misses        3913     3919       +6     

@alexander-branevskiy
Copy link
Contributor

LGTM

fix

fix

squashtrace
…latest xml reports, etc.

* preserve original class of Throwable in BIORunner.unsafeRun
* add BIOExit.Trace.unsafeAttachTrace
@neko-kai neko-kai merged commit 3fc05bd into develop Apr 20, 2020
@neko-kai neko-kai deleted the feature/matching-try branch April 20, 2020 00:03
@neko-kai neko-kai changed the title matching try distage-testkit: Fix recorded test error messages in sbt reports, scalatest xml reports, etc. Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants