Fix testkit on sbt launching tests defined in other test modules when depending on another test artifact #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depending on another test artifact This workaround alters the classpath scanning logic to only consider classes defined in the first `test-classes` directory encountered on the classpath to be those defined in 'current module'. It seems that for SBT the heuristic that the current test module classes will be placed in the first `test-classes` dir on the classpath generally holds. However, if it fails, you may be able to fix test running by overriding `_sbtIsClassDefinedInCurrentTestModule` or `_sbtFindCurrentTestModuleClasspathElement` in your tests to suit your needs. Also fix `DistageScalatestTestSuiteRunner#modifyClasspathScan` modifier not being applied (it was never applied, ugh...)
neko-kai
added a commit
that referenced
this pull request
Jan 19, 2024
- Make path comparisons less strict - Regression was caused by some classpath elements containing trailing / non-deterministically - Print a diagnostic message if test class filtering occured
neko-kai
added a commit
that referenced
this pull request
Jan 19, 2024
- Make path comparisons less strict - Regression was caused by some classpath elements containing trailing `/` non-deterministically - Print a diagnostic message if test class filtering occured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround alters the classpath scanning logic to only consider classes defined in the first
test-classesdirectory encountered on the classpath to be those defined in 'current module'. It seems that for SBT the heuristic that the current test module classes will be placed in the firsttest-classesdir on the classpath generally holds. However, if it fails, you may be able to fix test running by overriding_sbtIsClassDefinedInCurrentTestModuleor_sbtFindCurrentTestModuleClasspathElementin your tests to suit your needs.Also fix
DistageScalatestTestSuiteRunner#modifyClasspathScanmodifier not being applied (it was never applied, ugh...)