Bug: ConfigWriter minimizer does not omit nested unrequired nodes. #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a bug, it's a fundamental limitation of our codec model. Current codecs cannot provide metadata w/o execution and even during execution they cannot trace all possible code paths because the structures are polymorphic. So, we can't solve this perfectly w/o complete rethinking of our codec model (which is the same as in circe/pureconfig). |
pshirshov
force-pushed
the
bug/config-minimizer-does-not-omit-nested-nodes
branch
from
f507ed5
to
e81eb9f
Compare
pshirshov
force-pushed
the
bug/config-minimizer-does-not-omit-nested-nodes
branch
from
e81eb9f
to
83c4730
Compare
pshirshov
deleted the
bug/config-minimizer-does-not-omit-nested-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.