Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scala 3.4.0, memoization fixed on Scala 3 with update #2082

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Mar 7, 2024

No description provided.

@neko-kai neko-kai requested a review from pshirshov as a code owner March 7, 2024 08:50
@neko-kai neko-kai enabled auto-merge (squash) March 7, 2024 08:50
@neko-kai neko-kai merged commit 920376b into develop Mar 7, 2024
31 checks passed
@neko-kai neko-kai deleted the feature/update-to-scala-3.4.0 branch March 7, 2024 08:58
@SethTisue
Copy link

It came up today on Discord that someone was trying to use Izumi 1.2.6 on Scala 3.3, and that didn't work because of the 3.4 upgrade here. I'm curious if the 3.4 upgrade was somehow actually necessary, or if you weren't aware that Scala 3 libraries normally choose to continue supporting the last LTS release which was 3.3.

@pshirshov
Copy link
Member

pshirshov commented Jul 26, 2024

From what I can remember, there is a critical bug in 3.3 which breaks identity of izumi-reflect tags. We would be happy to stay on 3.3 but we can't.

@neko-kai
Copy link
Member Author

neko-kai commented Jul 26, 2024

@SethTisue We depend on the fix to scala/scala3#19224 which was released in 3.4.0. It's not quite viable for us to support older versions due to this. I hope they don't critically need 3.3 LTS support, and can update after all. They could permanently stay on an older version (and experience bugs in testkit due to above issue), but that would also be a very bad idea.

We are aware that it's probably best not to update Scala 3 when possible, our other libraries (izumi-reflect), still publish using 3.2

@pshirshov
Copy link
Member

We can downgrade, if the patch is backported into LTS.

@SethTisue
Copy link

I see. Maybe worth a mention in readme and/or doc page? Not sure.

if the patch is backported into LTS.

Looks to me like the fix is included in 3.3.4-RC1.

neko-kai added a commit that referenced this pull request Jul 29, 2024
neko-kai added a commit that referenced this pull request Jul 29, 2024
@neko-kai
Copy link
Member Author

@SethTisue Yes, we've been able to downgrade to 3.3.4-RC1 just now. Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants