Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config merge order, add test #2161

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Aug 7, 2024

Config merge order was reversed (common was higher application, *-reference was higher than regular)

Config merge order was reversed (common was higher application, *-reference was higher than regular)
@neko-kai neko-kai enabled auto-merge (squash) August 7, 2024 19:00
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.33%. Comparing base (ee07a39) to head (3fa939a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2161      +/-   ##
===========================================
- Coverage    66.50%   66.33%   -0.17%     
===========================================
  Files          589      581       -8     
  Lines        11446    11399      -47     
  Branches      1255     1250       -5     
===========================================
- Hits          7612     7562      -50     
- Misses        3834     3837       +3     

@neko-kai neko-kai merged commit 9155868 into develop Aug 8, 2024
32 of 33 checks passed
@neko-kai neko-kai deleted the feature/fix-config-order branch August 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant