Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add test workflow on CI #34

Merged
merged 11 commits into from
May 25, 2024
Merged

chore: Add test workflow on CI #34

merged 11 commits into from
May 25, 2024

Conversation

7nohe
Copy link
Owner

@7nohe 7nohe commented May 19, 2024 •
edited
Loading

  • Added a CI workflow to ensure that the generate command works correctly on all platforms
  • Organized the logs to make it easier to understand where the failure occurred and which options were used
  • Fixed some parts that were not working properly on Windows
  • Added the options SKIP_ARTISAN_COMMAND and KEEP_LARAVEL_JSON to enable functionality without requiring an Artisan command execution environment
Screenshot 2024-05-21 at 22 23 36

@7nohe 7nohe self-assigned this May 21, 2024
@7nohe 7nohe requested a review from NaoyaMiyagawa May 21, 2024 13:37
NaoyaMiyagawa
NaoyaMiyagawa approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@NaoyaMiyagawa NaoyaMiyagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console output looks amazing! LGTM✨

@7nohe 7nohe merged commit 9ea102a into main May 25, 2024
4 checks passed
@7nohe 7nohe deleted the chore/ci-test branch May 25, 2024 08:38
@7nohe 7nohe mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaoyaMiyagawa NaoyaMiyagawa NaoyaMiyagawa approved these changes

Assignees

@7nohe 7nohe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7nohe @NaoyaMiyagawa