added a Generate-Random-Password button to GUI #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "Generate Password" button to GUI
When editing an item one can now automatically pre-fill the password field with a random system generated password
The password mixes entropy from Trezor with entropy from the OS to generate a random password
The password is base64 encoded, with the base64 buffer char "=" removed, + and / replaced with - and _. And I and l as well as 0 and O have been removed because they are easily confused. So, in short, it is a slightly modified base64 encoding.
The "Generate Password" button can be clicked several times to create an arbitrary long random password (one click should be enough for everyone, 2 clicks for the extra careful).
Removed a spacer from the GUI which was a minor visual bug that prevented the comments field to move all the way down. Without the spacer it looks nicer and the screen real estate is utilized better.