Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new app character v3.5.0, change app code into change-character #92

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

9-9-9-9
Copy link
Owner

@9-9-9-9 9-9-9-9 commented Jan 26, 2023

No description provided.

@9-9-9-9 9-9-9-9 added the bug Something isn't working label Jan 26, 2023
@9-9-9-9 9-9-9-9 self-assigned this Jan 26, 2023
@9-9-9-9
Copy link
Owner Author

9-9-9-9 commented Jan 26, 2023

My IDE also detected

while (!characterLoaded && !masterSwitch.get()) {

The condition !characterLoaded is always true

if (clickImage(BwMatrixMeta.Metas.Character.Dialogs.loading)) {
                            debug("Character Loading!");
                            characterLoaded = true;
                            break;
                        }

characterLoaded = true the value true assigned to characterLoaded is never used

Copy link
Collaborator

@daredoes daredoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. We could change the code before merging this though.

@9-9-9-9
Copy link
Owner Author

9-9-9-9 commented Jan 27, 2023

My IDE also detected

while (!characterLoaded && !masterSwitch.get()) {

The condition !characterLoaded is always true

if (clickImage(BwMatrixMeta.Metas.Character.Dialogs.loading)) {
                            debug("Character Loading!");
                            characterLoaded = true;
                            break;
                        }

characterLoaded = true the value true assigned to characterLoaded is never used

@daredoes please double check this as well. I don't have a machine that can test rn. But I believe this new app already works as you expected, right?

@9-9-9-9 9-9-9-9 changed the title refactor: new app character v3.5.0 refactor: new app character v3.5.0, change app code into change-character Jan 27, 2023
@9-9-9-9 9-9-9-9 merged commit 11d2896 into master Jan 27, 2023
@9-9-9-9 9-9-9-9 deleted the refactor/v3.5.0 branch January 27, 2023 04:31
@daredoes
Copy link
Collaborator

My IDE also detected

while (!characterLoaded && !masterSwitch.get()) {

The condition !characterLoaded is always true

if (clickImage(BwMatrixMeta.Metas.Character.Dialogs.loading)) {
                            debug("Character Loading!");
                            characterLoaded = true;
                            break;
                        }

characterLoaded = true the value true assigned to characterLoaded is never used

@daredoes please double check this as well. I don't have a machine that can test rn. But I believe this new app already works as you expected, right?

This works as expected. I've been running it all day. I'll try to work on making some VM script to run this, as I think that's the best way to work around the keyboard/mouse capture.

@9-9-9-9
Copy link
Owner Author

9-9-9-9 commented Jan 27, 2023

This works as expected. I've been running it all day. I'll try to work on making some VM script to run this, as I think that's the best way to work around the keyboard/mouse capture.

👍 I had been using VM to run multiple accounts as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants