fix: fix Parcel.initialMeta value passing #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxinteractive
changed the title
mriccid
reviewed
Jan 14, 2019
| handleChange | ||
| }) | ||
| .initialMeta({a:1, b:2}) | ||
| .initialMeta({a:1, b:2}) // do nothing to data |
There was a problem hiding this comment.
How does this test confirm that nothing is done to the data after the second initialMeta call?
mriccid
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataparcels
Parcel.initialMetais set Bug: initialMeta deletes value #164react-dataparcels