Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Parcel.initialMeta value passing #169

Merged
merged 4 commits into from
Jan 14, 2019
Merged

fix: fix Parcel.initialMeta value passing #169

merged 4 commits into from
Jan 14, 2019

Conversation

dxinteractive
Copy link
Collaborator

@dxinteractive dxinteractive commented Jan 14, 2019 •
edited
Loading

dataparcels

react-dataparcels

  • No change

@dxinteractive dxinteractive changed the title test: improve Parcel.initialMeta tests fix: fix Parcel.initialMeta value passing Jan 14, 2019
mriccid
mriccid reviewed Jan 14, 2019
View reviewed changes
packages/dataparcels/src/parcel/__test__/ModifyMethods-test.js Outdated
handleChange
})
.initialMeta({a:1, b:2})
.initialMeta({a:1, b:2}) // do nothing to data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this test confirm that nothing is done to the data after the second initialMeta call?

@dxinteractive dxinteractive merged commit 7e35b9c into release/absolute-anaconda Jan 14, 2019
@dxinteractive dxinteractive deleted the feature/fix-initial-meta branch January 14, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccid mriccid mriccid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxinteractive @mriccid