Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for data returned from createRequestAction #138

Closed
wants to merge 1 commit into from
Closed

test: add tests for data returned from createRequestAction #138

wants to merge 1 commit into from

Conversation

dxinteractive
Copy link
Contributor

@dxinteractive dxinteractive commented Jan 20, 2020 •
edited
Loading

  • test: add tests for data returned from createRequestAction

@dxinteractive
Copy link
Contributor Author

As discussed - don't merge this. Having tests for return types from createRequestAction is worth having, but the thing its testing is wrong, createRequestAction should pass back promises or obeservables as it did before, and RequestHook should cope with whatever it gets transparently adding the normalised result

@allanhortle allanhortle deleted the feature/fix-request-hook-observable branch June 15, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dxinteractive