PanicHandler panics when returning errors.errorString rather than a gqlerror.Error

[HectorMalot]

What happened?

I have this simple panic handler for my graphql endpoint, it is the same as in the documentation: https://gqlgen.com/reference/errors/. However, when my code panics, this results in a second panic because the marshalling of the response to the client (in the gqlgen library) expects a gqlerror.Error type.

srv.SetRecoverFunc(func(ctx context.Context, err interface{}) error {
	return errors.New("internal server error") // This causes a panic in the marshalling process because it expects a gqlerror.Error not errors.errorString
})

What did you expect?

Successful error response to user.

Minimal graphql.schema and models to reproduce

N/A

versions

• gqlgen version: v0.14.0
• go version: v1.17.1
• dep or go modules: go modules

Suggestions

Simple would be to update the documentation to return a gqlerror.Error. Ideally the lib is updated to also handle normal errors, but I didn't have the time to look into this and determine how difficult that would be.

[StevenACoffman]

The default recover func was modified in #1394 but the documentation was not updated to reflect that.

The documentation to fix is here: https://github.com/99designs/gqlgen/blob/master/docs/content/reference/errors.md?plain=1#L112-L119

Also, the DefaultErrorPresenter needs to be modified to wrap non-gqlgqn errors to handle this better.