Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatic use of "embed" package generates the wrong path on windows #2190

Closed
vikstrous opened this issue May 23, 2022 · 1 comment
Closed

automatic use of "embed" package generates the wrong path on windows #2190

vikstrous opened this issue May 23, 2022 · 1 comment

Comments

@vikstrous
Copy link
Contributor

What happened?

#2119 caused a regression on windows because it generates file paths in an OS-dependent way while it should always use /. See docs for "embed":

The path separator is a forward slash, even on Windows systems.

What did you expect?

gqlgen should generate correct paths on windows

Minimal graphql.schema and models to reproduce

omitted... too long to include.. I'll just make the PR fixing it.

versions

  • go run github.com/99designs/gqlgen version? 0.17.7
  • go version? 1.18
@vikstrous vikstrous mentioned this issue May 23, 2022
Merged
1 task
vikstrous added a commit to vikstrous/gqlgen that referenced this issue May 23, 2022
@vikstrous
fix 99designs#2190 - don't use backslash for "embed" paths on windows
4ba8e0d
@vikstrous vikstrous mentioned this issue May 23, 2022
Merged
vikstrous added a commit to vikstrous/gqlgen that referenced this issue May 23, 2022
@vikstrous
fix 99designs#2190 - don't use backslash for "embed" paths on windows
9a9b0ac
vikstrous added a commit to vikstrous/gqlgen that referenced this issue May 23, 2022
@vikstrous
fix 99designs#2190 - don't use backslash for "embed" paths on windows
f63aef7
vikstrous added a commit to vikstrous/gqlgen that referenced this issue May 23, 2022
@vikstrous
fix 99designs#2190 - don't use backslash for "embed" paths on windows
04514a5
@frederikhors
Copy link
Collaborator

@StevenACoffman can you please release this?

This was referenced May 24, 2022
Closed
Merged
Open
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 18, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vikstrous @frederikhors