updates directive root structure #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vektah
reviewed
Jul 8, 2019
| } | ||
| ``` | ||
| *ctx*: passed from the resolver | ||
| *obj*: the payload aggregated so far |
There was a problem hiding this comment.
This can actually vary a bit, depending on where the directive was - #760
vektah
reviewed
Jul 8, 2019
| } | ||
| ``` | ||
| *ctx*: passed from the resolver | ||
| *obj*: the payload aggregated so far | ||
| *next*: signals that the directive was successful |
There was a problem hiding this comment.
next is the middleware pattern, it's not signaling success it's fetching the value by going through the rest of the stack.
|
Shipped with some tweaks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was incorrect in the way directives are generated, missing the body interface{}. I originally thought this was a bug until I checked what the object was and figured that should be in the documentation too
I have: