-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add execute argument and input directive #460
Conversation
Thanks for the PR, I'll try to review it as I get time. It's a pretty big change though, a bit more description would be appreciated as to how you've implemented this and how it affects the current directives implementation. |
update description |
This is a large PR to drop without any discussion beforehand :( We have been thinking to cover this use case (validation) via a codegen plugin rather than getting the user to wire them up for each graph. I'm getting lots of compile errors if I add a directive to some args in starwars:
|
invalid schema and for example if use
updated generate args |
added execution of system directives for ARGUMENT_DEFINITION and INPUT_FIELD_DEFINITION
generating code for arguments for example when adding a Directive instead of
will be
if the argument is type input, the code will be added in addition to the previous code and the previous code will be added (for example)
and added input middleware(for example) or empty middleware