Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1762: Reload packages before merging type systems #1763

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix #1762: Reload packages before merging type systems #1763

merged 2 commits into from
Jan 14, 2022

Conversation

ipfans
Copy link
Contributor

@ipfans ipfans commented Jan 14, 2022 •
edited by StevenACoffman
Loading

Fixes #1762 cfg.ReloadAllPackages() should be called before merging type systems.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 70.671% when pulling 71e41cd on ipfans:master into e5b5e83 on 99designs:master.

@StevenACoffman
run gofmt on file
71e41cd 
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit 931271a into 99designs:master Jan 14, 2022
@StevenACoffman
Copy link
Collaborator

Thanks for the fix!

@ipfans ipfans mentioned this pull request Jan 15, 2022
Closed
@StevenACoffman StevenACoffman mentioned this pull request Jan 16, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generated models across loaded packages causes error merging type systems
3 participants
@ipfans @coveralls @StevenACoffman