graphql: add FieldContext.Child field function and enable it in codegen #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
changed the title
a8m
force-pushed
the
childfield
branch
4 times, most recently
from
d6b2af0
to
0b60785
Compare
|
This is great! Thanks so much! |
|
Do we need to update docs for these changes? |
StevenACoffman
force-pushed
the
childfield
branch
from
0b60785
to
395b4c1
Compare
|
I rebased it for you to fix the conflicts |
|
Thanks, @StevenACoffman. @frederikhors, I'll extend the godoc for it before landing it. |
Yes, please. Features without docs == no features at all. |
StevenACoffman
approved these changes
Mar 25, 2022
|
Added godoc and merged. Thanks for the review @StevenACoffman and @frederikhors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pasting here the discussion from gqlgen Discord:
In Ent, we have a nice workaround for the N+1 problem when working with gqlgen (see https://entgo.io/docs/tutorial-todo-gql-field-collection#ent-solution), and we do it by reading the query fields recursively and constructing one Ent query for the GraphQL query.
However, we have a problem when a field accepts arguments as parameters - we can't get them today with the current API. We use "fields collection" to get the "raw arguments", but that's not enough as we need the "processed version" that exists in the
FieldContextin order to evaluate the Ent query.This PR adds a new field function to the
graphql.FieldContextnamedChildthat gets agraphql.CollectedFieldobject and returns the processedgraphql.FieldContextfor the collected field. This can also solve #1144.