Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional return pointers in unmarshalInput #2397

Merged
merged 2 commits into from
Sep 28, 2022
Merged

optional return pointers in unmarshalInput #2397

merged 2 commits into from
Sep 28, 2022

Conversation

LuciferInLove
Copy link
Contributor

@LuciferInLove LuciferInLove commented Sep 28, 2022 •
edited
Loading

Added an option to return pointers instead of values in unmarshalInput.
Default if false.
Doesn't break existing functionality.
#2384

I have:

  • [] Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.395% when pulling bbf21b3 on LuciferInLove:master into daa4407 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 906c0de into 99designs:master Sep 28, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciferInLove @coveralls @StevenACoffman