Allow setting headers in HTTP transports #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently gqlgen sets Content-Type header to 'application/json'. There's
no easy way to change it or add additional headers.
This commit adds struct variable ResponseHeaders that can hold any
headers you want to be returned with response. It is standard
`map[string][]string` variable.
If user does not set this map, we default to the Content-Type
header with 'application/json' value - nothing will be changed
for existing users.
Usage:
as simple as:
```
headers := map[string][]string{
"Content-Type": {"application/json; charset: utf8"},
"Other-Header": {"dummy-post-header","another-value"},
}
h.AddTransport(transport.POST{ResponseHeaders: headers})
```
Added tests in transport/headers_test.go.
RatkoR
changed the title
|
Thanks! This seems like a great addition, and I really appreciate you making it backward compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gqlgen sets Content-Type header to 'application/json'. There's no easy way to change it or add additional headers.
This commit adds struct variable ResponseHeaders that can hold any headers you want to be returned with response. It is standard
map[string][]stringvariable.If user does not set this map, we default to the Content-Type header with 'application/json' value - nothing will be changed for existing users.
Usage:
as simple as:
Added tests in transport/headers_test.go.
Describe your PR and link to any relevant issues.
I have: