Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return internal types in schema introspection #2773

Conversation

elad-aharon
Copy link
Contributor

@elad-aharon elad-aharon commented Aug 28, 2023

Closes #2772

according to graphql spec:

types: return the set of all named types contained within this schema.
Any named type which can be found through a field of any introspection type must be included in this set.

source: https://github.com/graphql/graphql-spec/blob/main/spec/Section%204%20--%20Introspection.md#the-__schema-type

some clients libs (like HotChocolate for C#) depends on this behavior.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

according to graphql spec:
```
types: return the set of all named types contained within this schema.
Any named type which can be found through a field of any introspection type must be included in this set.
```
source: https://github.com/graphql/graphql-spec/blob/main/spec/Section%204%20--%20Introspection.md#the-__schema-type

some clients libs (like HotChocolate for C#) depends on this behavior.
@coveralls
Copy link

coveralls commented Aug 28, 2023

Coverage Status

coverage: 75.746% (+0.05%) from 75.693% when pulling c5cb589 on elad-aharon:elad/schema_introspection_with_internal_types into 065aea3 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 1cde8c3 into 99designs:master Aug 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introspection internal types are omitted from response
3 participants