Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: short-lived dataloader in sample #2778

Merged
merged 1 commit into from
Sep 2, 2023
Merged

docs: short-lived dataloader in sample #2778

merged 1 commit into from
Sep 2, 2023

Conversation

zenyui
Copy link
Contributor

@zenyui zenyui commented Sep 2, 2023 •
edited
Loading

Describe your PR and link to any relevant issues.

This addresses the comment @vikstrous raised (PR) by making the data loader request-scoped (like the sample repo is)

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@zenyui zenyui mentioned this pull request Sep 2, 2023
Merged
vikstrous
vikstrous approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@vikstrous vikstrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@StevenACoffman StevenACoffman merged commit a41f4da into 99designs:master Sep 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikstrous vikstrous vikstrous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenyui @vikstrous @StevenACoffman