Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test TestSubscriptions #2779

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

vikstrous
Copy link
Contributor

The test failed in #2770

I noticed that the pattern of waiting for goroutines to match the number they were at the start of the test was missing from the second subtest.

I triggered the failure locally with

go test -race -test.run  'TestSubscriptions' -count 10000

This takes 3-4 minutes for me.

After the change, the test no longer failed after 10k iterations.

I noticed that there's a second copy of the same test and copied the fix to it too.

@StevenACoffman
Copy link
Collaborator

OMG, I have wanted this for soooooo long. That's why I made the tests retry. Thanks!

@StevenACoffman StevenACoffman merged commit bee47dc into 99designs:master Sep 5, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants