Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defer wg.Done() in FieldSet Dispatch #2861

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Use defer wg.Done() in FieldSet Dispatch #2861

merged 1 commit into from
Dec 13, 2023

Conversation

UnAfraid
Copy link
Contributor

Fixes #2860

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@UnAfraid UnAfraid mentioned this pull request Dec 13, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 75.936%. remained the same
when pulling 71411d1 on UnAfraid:bugfix/field-set-dispatch-wg-done
into 24ea195 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 7dd971c into 99designs:master Dec 13, 2023
18 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks!

@UnAfraid UnAfraid deleted the bugfix/field-set-dispatch-wg-done branch December 14, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Add defer for field resolvers
3 participants
@UnAfraid @coveralls @StevenACoffman