Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows compatibility to ImportPathForDir #788

Closed
wants to merge 1 commit into from

Conversation

dissipative
Copy link

Fixes #786

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 61.686% when pulling 0d8167d on dissipative:fix-imports into d2c5bf2 on 99designs:master.

@vektah
Copy link
Collaborator

vektah commented Aug 8, 2019

Sorry, we generally try to avoid if windows checks (except in tests).

I've fixed this in #822, instead of looking for / it stops as soon as the parent dir has the same path as the current dir.

@vektah vektah closed this Aug 8, 2019
@vektah vektah added the v0.9.2 label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init not works on Windows (eternal loop)
3 participants