Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UniquenessKey for when Element is/isn't nullable (#896) #900

Merged
merged 6 commits into from
Nov 11, 2019
Merged

Update UniquenessKey for when Element is/isn't nullable (#896) #900

merged 6 commits into from
Nov 11, 2019

Conversation

zannen
Copy link
Contributor

@zannen zannen commented Oct 13, 2019

With a schema:

type Query {
  things1: [Thing] # Note the lack of "!"
}

type Subscription {
  things2: [Thing!] # Note the "!"
}

the UniquenessKey for the two lists is the same, which causes non-deterministic output.

I have:

@coveralls
Copy link

coveralls commented Oct 13, 2019

Coverage Status

Coverage increased (+0.09%) to 62.162% when pulling 8a8f0a0 on zannen:master into 99a55da on 99designs:master.

@zannen
Copy link
Contributor Author

zannen commented Oct 21, 2019

I have no idea why the plugin/resolvergen race test is failing on CircleCI.

I ran the test over 2000 times locally and it succeeded every time:

while true ; do
  date
  go test -count=1 -race github.com/99designs/gqlgen/plugin/resolvergen
done

@vektah
Copy link
Collaborator

vektah commented Nov 11, 2019

Nice one!

@vektah vektah merged commit c1e6414 into 99designs:master Nov 11, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Update UniquenessKey for when Element is/isn't nullable (99designs#896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants