Add UI Page for OIDC Configuration

[strazto]

Partially resolves #2

For now, this only implements OID configuration, though gives a solid reference for SAML configuration, which will be similar.

Presently, options that take json objects require json to be given on the UI - For list items, this would be better as a multiline text field that splits on newlines, and more more complex mappings, something actually good needs to be made - but this will do for now.

[9p4]

Could you make the CI happy (it's all style)?

[strazto]

Could you make the CI happy (it's all style)?

Yep, I've updated my own build command to use --warnaserror too

[strazto]

Looks like it should pass CI checks now, seems to on my fork:

strazto#2

[strazto]

Should be RTM - The frontend issues are resolved now

[strazto]

This'll probably be annoying to rebase but that's what you get for not formatting your code, I've thrown both the html & js at prettier so far

[9p4]

I'm going to take this for a test run and merge once it all feels good :)

Thanks for the PR!

[strazto]

I'll wait to rebase #19 until I wait & see if you have more changes to request.

Happy to say that I've successfully used this to configure my dev server to authorize against my authelia instance, and was able to login with the most basic settings:

---
authelia:
  OidEndpoint: https://authelia.example.com/.well-known/openid-configuration/
  OidClientId: jellyfin
  OidSecret: <omitted>
  Enabled: true
  EnableAuthorization: true
  EnableAllFolders: true
  EnabledFolders: []
  Roles: []
  EnableFolderRoles: false
  FolderRoleMapping: []
  RoleClaim: a.b.d

[strazto]

So far I've noticed that there's not as much validation of configuration as there probably should be, particularly the json fields, whereby if they are left empty, there'll be runtime errors when you try to run your flow.

For now, the json fields that you want to leave unset seem to need some parse-able placeholder, [] or {}

[strazto]

Also, future work to make this actually feel nice is going to involve:

• client (or server) side mapping of folders to their respective ids
• a nice(er) UI for selecting folders, using LDAP auth as a reference:
  

[9p4]

A lot of nitpicky UX changes. Most are spelling/grammar/consistency but a few are for how data is input and may take a while to change.

[strazto]

@94p although I'd like to get the input changes in (json input is def not user friendly), I'd still call this an improvement over the previous system (no config page).
Will you consider pulling this as good-enough-for-now if I get the spelling / punctuation / help string comments fixed?

[9p4]

Yep!

[9p4]

I would prefer for an "Add" button to be added before I merge, however.

[strazto]

I would prefer for an "Add" button to be added before I merge, however.

If you mean to add a new oidc config, that's implemented- you fill out the form and press "add", at the bottom of the form.
If there's an entry loaded up, it updates that entry, but really it just writes to whatever entry has the corresponding "provider name"

I think I know what you're saying, though - to make the pattern more obvious, I could add a button up top "add" that just clears the form and maybe puts "new provider" into the name field, so the flow to add a new provider feels more obvious

[strazto]

When I get a second tomorrow, I'll address the style and spelling nits and then it'll be good to merge, with a clear path for how to get it usable enough to someday be beta-ready (I'll probably implement SAML config around the same time)

[9p4]

Again, thank you so much for this contribution!

[strazto]

Okay, awake now, I'll address those things - Not fully clear on the "Add" functionality I described here

I think I know what you're saying, though - to make the pattern more obvious, I could add a button up top "add" that just clears the form and maybe puts "new provider" into the name field, so the flow to add a new provider feels more obvious

I think if I improve the labeling of the add / update form, then it shouldn't be as necessary to implement a specific "Add" button, it should be clear what form does what.

[strazto]

Current UI

By default, "select existing" is collapsed.

[strazto]

Should be RTM. Feel free to squash on merge, it'll be a hassle to rebase regardless (I'd rather the two cleanup commits be squashed anyway)

Documenting comments / requests that won't be actioned this PR in #2 (comment)

[9p4]

I'll do some more testing this week but looks very good!