Mockable status codes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode is 200 and error for all other status codes. Merge in default status code 200.
Add test for support for specifying status code in response.
| @@ -95,7 +95,12 @@ function mock(superagent) { | |||
| if (current) { | |||
| setTimeout(function() { | |||
| try { | |||
| cb && cb(null, current(state.request)); | |||
| var response = current(state.request); | |||
| if (response.status !== 200) { | |||
There was a problem hiding this comment.
Just think the documentation needs to be clear after this is merged that status will refer to the status code returned. I could see people getting confused if they just have 'status' as a regular property name for part of a response payload and it causes their requests to return errors
|
Hi, guys! Is this pull-request going to be merged ever?:) |
|
Doesn't look like I have permission to merge? |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.