Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML doc comments #46

Closed
scottdorman opened this issue Sep 26, 2020 · 5 comments · Fixed by #55
Closed

XML doc comments #46

scottdorman opened this issue Sep 26, 2020 · 5 comments · Fixed by #55
Assignees

Comments

@scottdorman
Copy link
Contributor

There are a lot of places in the doc comments where it uses the syntax of <c>null</c> rather than <see langword="null"/>, or doesn't do anything and just uses plain text "null". Should these be updated to use the <see langword="null"/> syntax?

As an example, here is what the updated comment (for Requires.NotNull<T>(T, string?) would look like:

/// <summary>
/// Throws an exception if the specified parameter's value is null.
/// </summary>
/// <typeparam name="T">The type of the parameter.</typeparam>
/// <param name="value">The value of the argument.</param>
/// <param name="parameterName">The name of the parameter to include in any thrown exception.</param>
/// <returns>The value of the parameter.</returns>
/// <exception cref="ArgumentNullException">Thrown if <paramref name="value"/> is <c>null</c>.</exception>

/// <summary>
/// Throws an exception if the the specified parameter's value is <see langword="null" />.
/// </summary>
/// <typeparam name="T">The type of the parameter.</typeparam>
/// <param name="value">The value of the argument.</param>
/// <param name="parameterName">The name of the parameter to include in any thrown exception.</param>
/// <returns>The value of the parameter.</returns>
/// <exception cref="ArgumentNullException">Thrown if <paramref name="value"/> is <see langword="null" />.</exception>
@AArnott
Copy link
Owner

AArnott commented Sep 27, 2020

I would accept a PR that fixes this.
But I'm curious why it matters.

@scottdorman
Copy link
Contributor Author

It's a bit of nit, to be fair, but the <see langword="null"/> translates to null reference (Nothing in Visual Basic) as text. Really, this applies to true and false as well.

@AArnott
Copy link
Owner

AArnott commented Sep 27, 2020

Interesting. Thanks for the info.

@bjm-csse
Copy link
Contributor

Hey Scott, I am interested in working on this! Would you assign this to me please? Thanks!

@scottdorman
Copy link
Contributor Author

@bjm-csse That would be great! I don't have the ability to assign issues, but @AArnott can when he's able to.

@AArnott AArnott linked a pull request Oct 9, 2020 that will close this issue
AArnott added a commit that referenced this issue May 2, 2023
Use top-level test folder beside src folder for shipping projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants