Fix Deewain timers and turn-in emote #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LtRipley36706
added a commit
that referenced
this pull request
Nov 17, 2023
* Add Channeling Stone Hatchet recipe (#1592) Add Channeling Stone Hatchet recipe * Add proc rate to channeling bone bow (#1593) * Remove Swarm Demon Life Immunity (#1594) * Make Invisible Assailant skills MOA compliant (#1595) * Fix AOD Bridge Timer (#1596) * Fix Protecting Picketed Pets Bugs (#1597) * society fix for retail meta (#1598) error in text that retail meta would not proceed due to the missing , * Fix Deewain timers and turn-in emotes (#1599) * Fix GY colo timers (#1600) * Add missing recipes to lower mukkir slayer stones (#1601) * Fix Swamp Cavern gen (#1602) * Update some text to match retail meta (#1603) Co-authored-by: Ross Elliott <relliott@provismedia.com> * normalize * Update 69994 Night Club Attendant.sql * Ilte Krongal Co-Authored-By: Fire-Chimp <49045665+Fire-Chimp@users.noreply.github.com> Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com> * Create 69994.es * normalize * finalize --------- Co-authored-by: Boop-AC <90673082+Boop-AC@users.noreply.github.com> Co-authored-by: Fire-Chimp <49045665+Fire-Chimp@users.noreply.github.com> Co-authored-by: OptimShi <OptimShi@users.noreply.github.com> Co-authored-by: Ross Elliott <relliott@provismedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started from bug report: https://discord.com/channels/261242462972936192/729525560421646469/1169189606969835571
Claim 1: Defender doors (maze jump room) close too soon. (Currently 60 seconds)
People didn't stay around this room very long once the Fiery Defender was dead. The longest I could find was 2 minutes, 19 seconds on "PCAP Part 1\jojii2\pkt_2017-1-22_1485133915_log.pcap". I found no instances of the defenders respawning or the doors closing in either PCAP or video. The report indicated the door reset interval matched the respawn time, which seemed reasonable enough without conflicting evidence.
Claim 2: Reward room doors close too soon. (Currently 60 seconds)
People stayed around this room a lot longer after killing
DeewainIron Golem. The longest was in Lou's retail video (https://youtu.be/_BIQ-mDH0Hw?t=5370) at 7 minutes, 24 seconds. Once again, I could find no instances of the enemies respawning or the doors closing. Matching the respawn time seemed reasonable enough.Claim 3: Rock turn-in behavior is incorrect and there is no need to reflag between turn-ins.
I can find no attempts to turn in multiple rocks in PCAP or video. However, two different people are shown to have many rocks in their inventory:
PCAP Part 1\Kilzeer-01-31-2017\pcapfiles\pkt_2017-1-29_1485749812_log.pcap
PCAP Part 3\sc-random-stuff\pkt_2017-1-30_1485829205_log.pcap
in addition to the reporter who also claimed he horded turn-ins. I can't think of a good reason for multiple people to be doing this besides his explanation of the behavior (turn-in on a timer) so behavior was changed to match that.