Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics on splicing #2756

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Add metrics on splicing #2756

merged 2 commits into from
Sep 29, 2023

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 27, 2023

This is best effort but should already be pretty useful.

Please double check the attribution logic, as it's not trivial. 🙏

This is best effort but should already be pretty useful.
@pm47 pm47 requested a review from t-bast September 27, 2023 16:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #2756 (b58a3bd) into master (e3ba524) will increase coverage by 0.07%.
Report is 5 commits behind head on master.
The diff coverage is 98.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
+ Coverage   85.75%   85.83%   +0.07%     
==========================================
  Files         216      216              
  Lines       18061    18089      +28     
  Branches      743      738       -5     
==========================================
+ Hits        15488    15526      +38     
+ Misses       2573     2563      -10     
Files Coverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 93.37% <100.00%> (+0.04%) ⬆️
...r/acinq/eclair/blockchain/fee/OnChainFeeConf.scala 95.00% <ø> (-0.24%) ⬇️
...cala/fr/acinq/eclair/channel/ChannelFeatures.scala 100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/Commitments.scala 96.82% <100.00%> (+<0.01%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala 94.51% <100.00%> (+0.02%) ⬆️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 85.94% <100.00%> (+0.64%) ⬆️
...q/eclair/channel/fsm/ChannelOpenSingleFunded.scala 93.46% <100.00%> (ø)
...inq/eclair/channel/fund/InteractiveTxBuilder.scala 91.47% <100.00%> (+0.10%) ⬆️
...cinq/eclair/channel/fund/InteractiveTxFunder.scala 92.18% <100.00%> (ø)
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 87.60% <100.00%> (ø)
... and 3 more

... and 6 files with indirect coverage changes

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribution looks correct 👍

@pm47 pm47 requested a review from t-bast September 29, 2023 11:20
@pm47 pm47 merged commit f6dbefd into master Sep 29, 2023
1 check passed
@pm47 pm47 deleted the splice-metrics branch September 29, 2023 11:33
pm47 added a commit that referenced this pull request Sep 29, 2023
pm47 added a commit that referenced this pull request Sep 29, 2023
pm47 added a commit that referenced this pull request Sep 29, 2023
We were considering all local outputs as splice outputs, but some may be change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants