Phoenix dockerized deterministic build #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dockerfile for dockerized build environment - Attach eclair-core artifact (temporary)
araspitzu
force-pushed
the
deterministic_build
branch
from
23a42e7
to
0d1f093
Compare
araspitzu
force-pushed
the
deterministic_build
branch
from
9e006e6
to
aabf7bf
Compare
|
I tested this and can generate the exact same release apks on 2 different machines. Debug apks are different but it's not an issue as we won't release them. |
dpad85
pushed a commit
that referenced
this pull request
Sep 15, 2021
Converting settings view into a scrollable list, and adding icons for each option. Fixes issue #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a docker image (via Dockerfile) that can be used to build phoenix without installing android studio or the android sdk dependencies, the build is also deterministic. Note that you need to build and publish locally
eclair-corefor this to work.