Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageFiltered Feature Added #295

Merged
merged 7 commits into from
Oct 25, 2021

Conversation

japneetsingh035
Copy link
Contributor

@japneetsingh035 japneetsingh035 commented Oct 24, 2021

Task 1: Feature of ImageFilter to blur an image added to the Project.
Task 2: Fixed some bugs with: "error resolved: missing code string in widget list line:914

After:
Screen Shot 2021-10-24 at 5 03 55 AM
Screen Shot 2021-10-24 at 5 04 07 AM
Screen Shot 2021-10-24 at 5 04 15 AM

@acmbot
Copy link

acmbot bot commented Oct 24, 2021

Thanks @japneetsingh035, for opening the pull request! 🙌
One of our team-mates will review the pull request soon. ✅

@japneetsingh035
Copy link
Contributor Author

Once merged, please close the issue: #284

@AryanKhubchandani AryanKhubchandani linked an issue Oct 24, 2021 that may be closed by this pull request
Copy link
Member

@AryanKhubchandani AryanKhubchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @japneetsingh035, I would like you to make some changes though:

  1. Remove the extra appBar from the implementation. It is not needed
  2. Include more filters like matrix to showcase transform, enlarge, shrink and other features which can implemented using this widget.

@japneetsingh035
Copy link
Contributor Author

Hi @AryanKhubchandani, Please consider a new commit with more features of ImageFilteredWidget.
After:
Screen Shot 2021-10-25 at 3 38 03 AM

Copy link
Member

@AryanKhubchandani AryanKhubchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @japneetsingh035, great work!

@acmbot
Copy link

acmbot bot commented Oct 25, 2021

Congratulations @japneetsingh035, your pull request is merged! 🎉
Thanks for your contributions. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ImageFiltered Widget to the Widget Catalog
2 participants