Implement Event and Stats fields needed to display coverage stats #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyone who wants to display coverage can do so by sending FeedbackEvent using the event manager (who implements EventFirer)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
FeedbackEvent.The
FeedbackEventholds a counter with the total number of unique points it has seen. For example when using for coverage it describes the total number of edges seen up until now. This event can be sent by anyone with access to the event manager, in my case I implemented a shared memory observer which sends an event when execution hooks are called and before zeroing out the memory (only if seen new edges).One thing I wasn't sure about was how to print out the data, In my case I have one client but when I will have more than one it wouldn't make sense to sum it up like we do with executions so I just defaulted to printing the whole slice.
Let me know what you think