Refactor stages to allow for continuation after crashes #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status? :) We could also just move parts of the stages I guess? |
|
@addisoncrump was going to try to implement some magic for the executor issue... |
|
Do we want this for next release? If so I can rebase and try to implement the fix for executor. |
Yes? :D |
|
i'll not merge executor0701 branch so i made this pr point to main |
2 tasks
|
@addisoncrump if you ever find the time... |
Merged
|
So this is superseeded by #1780 right? |
|
i guess so also this is based on my un-merged failed branch. so it can't be merged anymore |
|
Reopen if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the stages to allow for continuation at the point we left off after a crash, which is necessary for e.g. crash exploration.