-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change centralized launcher signature #2094
Conversation
Hmm this way we cannot simply swap out launchers anymore, could this be part of the |
IMO run_client should be doing different things depending on if it is the main node or the non-main node. Most common pattern is if it is main node. users should use empty tuple for the stages. |
Then centralized should probably have an extra callback, but the normal one/the one that fuzzes should have the same signature to keep them swappable |
Agree with @domenukk - keep run_client the same and add a run_main or something. |
Roger |
it should accept is_main as boolean