Match by Ref fix #2105
Merged
Match by Ref fix #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
addisoncrump
force-pushed
the
match-by-ref-ref
branch
from
e997ebb
to
c1be658
Compare
|
We need |
domenukk
reviewed
Apr 25, 2024
addisoncrump
commented
Apr 25, 2024
| .observers_mut() | ||
| .match_by_ref_mut(observer_ref) | ||
| .unwrap() | ||
| executor.observers_mut()[&observer_ref] |
There was a problem hiding this comment.
Definitely increases the WTF/line 🤣
|
|
addisoncrump
commented
Apr 26, 2024
libafl_sugar/Cargo.toml
Outdated
| @@ -17,7 +17,7 @@ all-features = true | |||
|
|
|||
| [features] | |||
| python = ["pyo3", "libafl_qemu/python", "pyo3-build-config"] | |||
| default = [] | |||
| default = ["libafl/adaptive_serialization"] | |||
There was a problem hiding this comment.
clippy flat out refused to pass if this wasn't enabled. I'm not sure how to get around this.
|
Just some last fixes in some fuzzers now. I'll circle back to this in the morning 🥱 |
|
Okay, supposing the QEMU runnres pass, this is ready to go 📈 |
domenukk
reviewed
Apr 27, 2024
| @@ -355,6 +355,7 @@ fn fuzz( | |||
| let cmpmap = unsafe { OwnedRefMut::from_shmem(&mut cmplog_shmem) }; | |||
|
|
|||
| let cmplog_observer = AFLppCmpLogObserver::new("cmplog", cmpmap, true); | |||
| let cmplog_ref = cmplog_observer.type_ref(); | |||
There was a problem hiding this comment.
Yeah that's more in-line with what we're using now anyways. I'll do a mass find-replace and merge, then.
|
Looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could've just opened a PR I guess. Closes #2104.