cfg fixup #2154
cfg fixup #2154
Conversation
|
@addisoncrump it's already done for libafl_qemu btw |
| @@ -2543,7 +2543,7 @@ where | |||
| // Crete a new ShMemProvider for this background thread | |||
| let shmem_provider_bg = SP::new().unwrap(); | |||
|
|
|||
| #[cfg(fature = "llmp_debug")] | |||
There was a problem hiding this comment.
It happens lol, one of the reasons I'm doing this
| @@ -26,7 +26,7 @@ use core::{fmt::Debug, time::Duration}; | |||
| #[cfg(feature = "std")] | |||
| use std::time::Instant; | |||
|
|
|||
| #[cfg(feature = "no_std")] | |||
| #[cfg(not(feature = "std"))] | |||
There was a problem hiding this comment.
Wait, how did that ever work/not warn or error?
|
Well, hold your horses, it's not over yet 😅 |
There was a problem hiding this comment.
Looks like this file is getting generated inconsistently; we shouldn't have it in the repo, and instead should just be generated at compile time.
There was a problem hiding this comment.
These are the stub bindings, they are only for testing and clippy and so on
There was a problem hiding this comment.
I'm not so sure. @andreafioraldi or @rmalmain: How do we reduce instability here? My bindgen output for this file is inconsistent with y'all's.
|
I think the apple thing is broken |
|
Fixed |
|
No clue where this is from/ how to fix this: error[E0432]: unresolved import `crate::FastSnapshotPtr`
--> libafl_qemu/src/qemu/systemmode.rs:18:26
|
18 | EmulatorMemoryChunk, FastSnapshotPtr, GuestAddrKind, MemAccessInfo, Qemu, QemuExitError,
| ^^^^^^^^^^^^^^^ no `FastSnapshotPtr` in the root
|
note: type alias `crate::emu::systemmode::FastSnapshotPtr` exists but is inaccessible
--> libafl_qemu/src/emu/systemmode.rs:55:1
|
55 | pub type FastSnapshotPtr = *mut libafl_qemu_sys::SyxSnapshot;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not accessible
For more information about this error, try `rustc --explain E0432`.
error: could not compile `libafl_qemu` (lib) due to 1 previous error |
|
Great stuff |
Recently, cfg checking was stabilized. This attempts to resolve the issues in CI associated with this.