Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force everyone to use French dictionary. #66

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Don't force everyone to use French dictionary. #66

merged 1 commit into from
Oct 13, 2021

Conversation

JulienPalard
Copy link
Contributor

Closes #65

@JulienPalard JulienPalard mentioned this pull request Oct 13, 2021
Closed
@christopheNan
Copy link

Thanks Julien.
Your code assumes that the user provides an URL. Considering that the issue raises a proxy filtering, it may be interesting to support a file as dict.

@vpoulailleau
Copy link
Member

vpoulailleau commented Oct 13, 2021 •
edited
Loading

Thanks for this PR, that I was going to merge. But I think that the comment from @christopheNan is also interesting. Maybe it's possible to have several URLs and several files, and merge them in a personal dict. What do you think @JulienPalard?

@JulienPalard
Copy link
Contributor Author

Like this?

christopheNan
christopheNan approved these changes Oct 13, 2021
View reviewed changes
Copy link

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christopheNan christopheNan mentioned this pull request Oct 13, 2021
Closed
@vpoulailleau vpoulailleau merged commit 5f3e154 into AFPy:master Oct 13, 2021
@vpoulailleau
Copy link
Member

vpoulailleau commented Oct 13, 2021 •
edited
Loading

Perfect. Thanks @JulienPalard and @christopheNan. Let's release a new version of padpo...

@JulienPalard JulienPalard deleted the mdk-no-default-personal-dict branch October 13, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopheNan christopheNan christopheNan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French Personal dict is mandatory fetched every startup
3 participants
@JulienPalard @christopheNan @vpoulailleau