Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Qdrant import / collection not working #94

Closed
wants to merge 1 commit into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented May 13, 2024

Description

This pull request addresses an issue with the Qdrant import functionality, specifically related to the handling of collections. The changes streamline the process by removing unnecessary retrieval of the on_disk parameter from the namespace metadata, which is not required for the import process.

Summary

  • Removed the extraction of the on_disk parameter from the namespace metadata in qdrant_import.py. This parameter was not utilized in the subsequent logic and its extraction was unnecessary.
  • Simplified the get_nested_config function calls by eliminating the redundant retrieval of the on_disk configuration, making the code cleaner and more efficient.
  • Adjusted the VectorParams initialization to exclude the on_disk parameter, aligning with the removal of its extraction and ensuring consistency in parameter usage.

These changes are confined to the src/vdf_io/import_vdf/qdrant_import.py file, specifically impacting how configuration parameters are handled during the import process to Qdrant collections.

Fixes #93.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-ai bot commented May 13, 2024

Rollback Files For Sweep

  • Rollback changes to src/vdf_io/import_vdf/qdrant_import.py

This is an automated message generated by Sweep AI.

@sweep-ai sweep-ai bot added the sweep Sweep your software chores label May 13, 2024
@sweep-ai sweep-ai bot mentioned this pull request May 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Sweep your software chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qdrant import / collection not working
1 participant