Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice and scripts/check_copyright.py script #62

Merged
merged 4 commits into from
May 17, 2023

Conversation

marcofavorito
Copy link
Member

Proposed changes

  • Update copyright notice end year: from 2022 to 2023
  • Update scripts/check_copyright.py script (make it executable)

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

The end year of the copyright notice was 2022; bumped to 2023.
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #62 (878c885) into main (75ecdf4) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files          20       20           
  Lines        1050     1050           
  Branches      163      163           
=======================================
  Hits          917      917           
  Misses        104      104           
  Partials       29       29           
Flag Coverage Δ
unittests 87.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pddl/__init__.py 100.00% <ø> (ø)
pddl/__main__.py 82.60% <ø> (ø)
pddl/__version__.py 100.00% <ø> (ø)
pddl/core.py 92.41% <ø> (ø)
pddl/custom_types.py 100.00% <ø> (ø)
pddl/exceptions.py 57.14% <ø> (ø)
pddl/formatter.py 98.07% <ø> (ø)
pddl/helpers/__init__.py 100.00% <ø> (ø)
pddl/helpers/base.py 93.75% <ø> (ø)
pddl/helpers/cache_hash.py 94.28% <ø> (ø)
... and 10 more

This is not needed since we use Python 3+.

To reproduce the replacement of the coding headers:

  find . \( -type d -name .git -prune \) -o -type f -print0 | xargs -0 sed -i -z "s/# -\*- coding: utf-8 -\*-\n//g"
@marcofavorito marcofavorito marked this pull request as ready for review May 15, 2023 09:56
Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@marcofavorito marcofavorito merged commit ee1edae into main May 17, 2023
@marcofavorito marcofavorito deleted the fix-copyright-notice branch May 17, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants