-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hierarchy 2 #75
Type hierarchy 2 #75
Conversation
d504620
to
37b4f4e
Compare
Thank you! |
37b4f4e
to
86dbb75
Compare
86dbb75
to
6c47b9f
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## fix/type_hierarchy #75 +/- ##
===================================================
Coverage 88.62% 88.62%
===================================================
Files 20 20
Lines 1064 1064
Branches 169 169
===================================================
Hits 943 943
Misses 94 94
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. |
assert domain.types == { | ||
"truck": "vehicle", | ||
"airplane": "vehicle", | ||
"package": "physobj", | ||
"vehicle": "physobj", | ||
"airport": "place", | ||
"location": "place", | ||
"city": "object", | ||
"place": "object", | ||
"physobj": "object", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francescofuggitti should we enforce the presence of "object": None
? That is, the types
dictionary should contain as keys all the root nodes (or leaves nodes, depending on how we see the inheritance relationship).
continuing on main PR |
Proposed changes
This is a sub-PR to #73 to add changes in a more trackable way.
Fixes
n/a
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.Further comments
n/a