Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hierarchy 2 #75

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

marcofavorito
Copy link
Member

Proposed changes

This is a sub-PR to #73 to add changes in a more trackable way.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@marcofavorito marcofavorito force-pushed the fix/type_hierarchy-2 branch 2 times, most recently from d504620 to 37b4f4e Compare June 2, 2023 16:29
@francescofuggitti
Copy link
Collaborator

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #75 (6c47b9f) into fix/type_hierarchy (9d195b0) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           fix/type_hierarchy      #75   +/-   ##
===================================================
  Coverage               88.62%   88.62%           
===================================================
  Files                      20       20           
  Lines                    1064     1064           
  Branches                  169      169           
===================================================
  Hits                      943      943           
  Misses                     94       94           
  Partials                   27       27           
Flag Coverage Δ
unittests 88.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Comment on lines +111 to +121
assert domain.types == {
"truck": "vehicle",
"airplane": "vehicle",
"package": "physobj",
"vehicle": "physobj",
"airport": "place",
"location": "place",
"city": "object",
"place": "object",
"physobj": "object",
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francescofuggitti should we enforce the presence of "object": None? That is, the types dictionary should contain as keys all the root nodes (or leaves nodes, depending on how we see the inheritance relationship).

@marcofavorito marcofavorito marked this pull request as ready for review June 2, 2023 17:36
@marcofavorito
Copy link
Member Author

continuing on main PR

@marcofavorito marcofavorito merged commit 6800afe into fix/type_hierarchy Jun 2, 2023
@marcofavorito marcofavorito deleted the fix/type_hierarchy-2 branch June 2, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants