Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change finalise prompt to INFO and update R stuff #116

Merged
merged 8 commits into from
Jul 13, 2023

Conversation

rpreen
Copy link
Collaborator

@rpreen rpreen commented Jul 13, 2023

Resolves #69

Changes:

  • updates the R wrapper to include new acro functionality
  • exception handling prompt in finalise() changes from print statements to INFO because the R outputs were prompting for user input before displaying the ouput.
  • adds version number to acro INFO
  • updates the two R notebooks

@rpreen rpreen linked an issue Jul 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #116 (ffdb92b) into main (8175789) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   97.13%   97.14%           
=======================================
  Files           6        6           
  Lines         664      666    +2     
=======================================
+ Hits          645      647    +2     
  Misses         19       19           
Impacted Files Coverage Δ
acro/acro.py 98.97% <100.00%> (+0.01%) ⬆️
acro/record.py 98.48% <100.00%> (ø)

@rpreen rpreen merged commit f984054 into main Jul 13, 2023
@rpreen rpreen deleted the 69-adapt-example-r-script-to-use-the-nursery-dataset branch July 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt example R script to use the nursery dataset
1 participant