Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic table suppression disabled as default #91

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

rpreen
Copy link
Collaborator

@rpreen rpreen commented Jun 29, 2023

Resolves #82

Added suppress: bool argument to the ACRO constructor, which defaults to False.

For crosstab() and pivot_table() a new Boolean field "suppressed" is added to the properties dictionary to indicate whether the output table (csv in JSON) has been suppressed.

@rpreen rpreen marked this pull request as draft June 29, 2023 14:45
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #91 (ff53d1d) into main (59a8f44) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   97.09%   97.20%   +0.11%     
==========================================
  Files           4        4              
  Lines         447      465      +18     
==========================================
+ Hits          434      452      +18     
  Misses         13       13              
Impacted Files Coverage Δ
acro/acro.py 98.83% <100.00%> (+0.05%) ⬆️
acro/record.py 98.10% <100.00%> (ø)
acro/utils.py 94.02% <100.00%> (+0.48%) ⬆️

@rpreen rpreen marked this pull request as ready for review June 29, 2023 15:46
@rpreen rpreen requested a review from jim-smith June 29, 2023 15:47
@rpreen rpreen added the Sprint2 label Jun 29, 2023
@rpreen rpreen merged commit 8de9a9c into main Jun 30, 2023
@rpreen rpreen deleted the 82_optional_suppression branch June 30, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default behaviour to not suppressing outputs
2 participants