Add support for directories of files without ACRO metdata #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means changing to use a directory picker, rather than a file picker. This means a bit of guess work when there are acro metadata files in the directory. The upshot of this is: a) we now launch the app in a special /load url to do this guess work b) we no longer support a directory with multiple acro metadata files in
bloodearnest
force-pushed
the
directories
branch
from
583098d
to
fe92036
Compare
|
Fixes #235 |
bloodearnest
force-pushed
the
directories
branch
from
b705e78
to
a85fa60
Compare
- better comment text - calculate checksums to silence notice It'd be better to switch off checkshums in the non-ACRO case. But that trickier, so this hack should work
lucyb
approved these changes
Oct 18, 2023
| @@ -73,20 +83,16 @@ const createWindow = async () => { | |||
| }); | |||
|
|
|||
| const result = await dialog.showOpenDialog({ | |||
| title: "Choose ACRO outputs json file", | |||
| properties: ["openFile"], | |||
| title: "Choose directory containing outputs you wish to review", | |||
There was a problem hiding this comment.
I think Windows tends to use "folder" rather than directory. However, I appreciate that's super picky and might not be worth changing.
There was a problem hiding this comment.
Hmm, yeah, perhaps that would be better. I may change it in later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means changing to use a directory picker, rather than a file
picker. This means a bit of guess work when there are acro metadata
files in the directory. The upshot of this is:
a) we now launch the app in a special /load url to do this guess work
b) we no longer support a directory with multiple acro metadata files in
Fixes #235