check the owners file in the repo as well as github association rules #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
requested review from
fridex,
goern and
harshad16
as code owners
sesheta
added
the
size/XS
Gregory-Pereira
force-pushed
the
init-task-check-repo-owners-file
branch
from
d75bdf5
to
fd13db8
Compare
sesheta
added
size/S
|
/retest |
|
@Gregory-Pereira: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gregory-Pereira
force-pushed
the
init-task-check-repo-owners-file
branch
from
fd13db8
to
7af53f1
Compare
|
Local pre-commit passes, ready for review. |
codificat
reviewed
Nov 3, 2021
sesheta
added
the
do-not-merge/hold
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
sesheta
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
|
/unhold |
sesheta
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
The issue is that permissions are only checked by a developer's access to GitHub organizations, but we want the ability to easily modify and add privileges to others to make changes.
Additionally, ran pre-commit and linted the sesheta request issue template so that the pre-commit check can pass.
This introduces a breaking change
This Pull Request implements
After receiving the response on the PR, the task will now read the owners file and include that in its searching to see if a user has access to the repository.
Description
issue itself still waiting to be created.