Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources for container build steps #156

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

Fixes thoth-station/kebechet#962
where the pipeline failed to build the image:

[pipenv.exceptions.InstallError]:     gcc: fatal error: Killed signal terminated program cc1plus
[pipenv.exceptions.InstallError]:     compilation terminated.
[pipenv.exceptions.InstallError]:     error: command '/usr/bin/gcc' failed with exit code 1

This introduces a breaking change

Nope

This Pull Request implements

Add requests and limits to the build steps that invoke buildah bud, the same way they are in other tasks like the tag-release task:

resources:
limits:
memory: "8Gi"
cpu: "2"
requests:
memory: "2Gi"
cpu: "2"
script: |
buildah bud \

Signed-off-by: Pep Turró Mauri <pep@redhat.com>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Contributor

sesheta commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@harshad16 harshad16 merged commit 481b4a7 into AICoE:master Jan 14, 2022
@codificat codificat deleted the build-resources branch January 14, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deliver Container Image
3 participants