-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create task to test the Thoth GitHub Action #178
Conversation
ee5e086
to
f4ec518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 💯
some suggestions
export GIT_SSH_COMMAND='ssh -i /tekton/home/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no' | ||
git add . | ||
git commit -m ":white_check_mark: Test the Thoth GitHub Action." || exit 0 | ||
git pull --rebase origin $(params.default_branch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be good if we have branch name created based on the test
git pull --rebase origin $(params.default_branch) | |
git pull --rebase origin `test-$(params.head_commit_hash)` |
git pull --rebase origin $(params.default_branch) | |
git pull --rebase origin $(params.default_branch) |
Thanks @harshad16 💯 Changes added in 76cb72b |
@mayaCostantini thanks for changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
Related to #177
This introduces a breaking change
This Pull Request implements
Implement a task to test the Thoth GitHub Action on the https://github.com/mayaCostantini/test-thoth-github-action external repository.
This task pacthes the commit of the last change from the Thoth GitHub Action repository in the test workflow files and generates a dummy change in all the dependency requirement files located in the overlays directory of the test repository to trigger the action workflows.