Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task to test the Thoth GitHub Action #178

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to #177

This introduces a breaking change

  • No

This Pull Request implements

Implement a task to test the Thoth GitHub Action on the https://github.com/mayaCostantini/test-thoth-github-action external repository.
This task pacthes the commit of the last change from the Thoth GitHub Action repository in the test workflow files and generates a dummy change in all the dependency requirement files located in the overlays directory of the test repository to trigger the action workflows.

@sesheta sesheta requested a review from pacospace June 3, 2022 14:55
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 💯
some suggestions

tasks/test-thoth-github-action.yaml Outdated Show resolved Hide resolved
export GIT_SSH_COMMAND='ssh -i /tekton/home/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no'
git add .
git commit -m ":white_check_mark: Test the Thoth GitHub Action." || exit 0
git pull --rebase origin $(params.default_branch)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be good if we have branch name created based on the test

Suggested change
git pull --rebase origin $(params.default_branch)
git pull --rebase origin `test-$(params.head_commit_hash)`
Suggested change
git pull --rebase origin $(params.default_branch)
git pull --rebase origin $(params.default_branch)

tasks/test-thoth-github-action.yaml Show resolved Hide resolved
tasks/test-thoth-github-action.yaml Show resolved Hide resolved
tasks/test-thoth-github-action.yaml Show resolved Hide resolved
@mayaCostantini
Copy link
Contributor Author

Thanks @harshad16 💯 Changes added in 76cb72b

@harshad16
Copy link
Member

@mayaCostantini thanks for changes
i think i made a mistake, can you revert the default_branch changes.
i thought you were pushing to default_branch, however it is going to push to github-test-action
so that is good.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 💯

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
@sesheta
Copy link
Contributor

sesheta commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@sesheta sesheta merged commit c4749cf into AICoE:master Jun 10, 2022
@mayaCostantini mayaCostantini deleted the test-thoth-action branch June 10, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants